Fix blog route matching article header#769
Conversation
👷 Deploy request for tanstack pending review.Visit the deploys page to approve it
|
📝 WalkthroughWalkthroughA blog post markdown file is updated to modify image references: the first image's alt text is renamed from "Big performance number" to "Header," and a new image for big-number.png is added with surrounding spacing. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6964b7c572
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| --- | ||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
The new top-of-article image points to header.png, which in this commit is a 3,391,000-byte PNG (public/blog-assets/tanstack-router-route-matching-tree-rewrite/header.png), roughly 100× larger than the previous header asset. Because this image is rendered at the start of the post, every reader pays this transfer cost up front, which will noticeably hurt page load/LCP on slower networks; please resize/compress or switch to a more efficient format before using it as the header.
Useful? React with 👍 / 👎.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/blog/tanstack-router-route-matching-tree-rewrite.md`:
- Line 9: The image markdown currently uses a generic alt text "Header" in the
line containing
"";
replace that alt text with a meaningful description (e.g., "Fantasy landscape
illustration used as the article header") or make it decorative by using an
empty alt (``), updating the markdown line
accordingly so screen readers receive either the descriptive text or treat the
image as decorative.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d5adcc53-e648-4fae-a1ed-ecf8e6cfea9c
⛔ Files ignored due to path filters (2)
public/blog-assets/tanstack-router-route-matching-tree-rewrite/big-number.pngis excluded by!**/*.pngpublic/blog-assets/tanstack-router-route-matching-tree-rewrite/header.pngis excluded by!**/*.png
📒 Files selected for processing (1)
src/blog/tanstack-router-route-matching-tree-rewrite.md
| --- | ||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
Use meaningful alt text (or empty alt if decorative).
On Line 9, Header is too generic for screen readers. Please either provide descriptive alt text (e.g., “Fantasy landscape illustration used as the article header”) or make it decorative with empty alt text ().
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/blog/tanstack-router-route-matching-tree-rewrite.md` at line 9, The image
markdown currently uses a generic alt text "Header" in the line containing
"";
replace that alt text with a meaningful description (e.g., "Fantasy landscape
illustration used as the article header") or make it decorative by using an
empty alt (``), updating the markdown line
accordingly so screen readers receive either the descriptive text or treat the
image as decorative.
2 participants
Just adding a header image because with the new layout, the previous one just wasn't nice anymore (wasn't the best before either)
before
after
Summary by CodeRabbit